[14.0][MIG] sale promotion rule #1583

xavier-bouquiaux · 2021-05-11T13:53:54Z

No description provided.

rousseldenis · 2021-05-18T08:11:15Z

@hparfr IMHO, either a Roadmap, either a modification before merge should integrate coupon module that has been split by Odoo from 13 => 14 as it could be interesting to base our flow on coupon.coupon model

https:/odoo/odoo/blob/14.0/addons/coupon/models/coupon.py#L10

Not too much logic there, no mandatory fields. What do you think ?

@sebastienbeau @Cedric-Pigeon @qgroulard

hailangvn

Thanks for the PR. There are minor improvements not required to merge this.

hailangvn · 2021-05-19T15:50:40Z

sale_promotion_rule/views/sale_promotion_rule.xml

+ <group name="condition" string="Condition" col="3">
+ <label for="date_from" string="Date début/fin" />
+ <field name="date_from" nolabel="1" />
+ <field name="date_to" nolabel="1" />
+ <field name="minimal_amount" colspan="3" />
+ <field name="is_minimal_amount_tax_incl" colspan="3" />
+ <field name="only_newsletter" colspan="3" />
+ <field
+ name="restrict_pricelist_ids"
+ widget="many2many_tags"
+ colspan="3"
+ />
+ <label for="restrict_partner_ids" colspan="3" />
+ <field
+ name="restrict_partner_ids"
+ nolabel="1"
+ colspan="3"
+ />
+ </group>
+ </group>


</group> <group name="condition" string="Condition" col="6"> <label for="date_from" string="Date début/fin"/> <field name="date_from" nolabel="1"/> <field name="date_to" nolabel="1"/> <field name="minimal_amount" colspan="3"/> <field name="is_minimal_amount_tax_incl" colspan="3"/> <field name="only_newsletter" colspan="3"/> <field name="restrict_pricelist_ids" widget="many2many_tags" colspan="3"/> <label for="restrict_partner_ids" colspan="6"/> <field name="restrict_partner_ids" nolabel="1" colspan="6"/> </group>

@hailangvn This is reformated through pre-commit.

Thanks @rousseldenis. I was new at the time I commented. :)

hailangvn · 2021-05-19T16:13:55Z

sale_promotion_rule/demo/product.xml

+<?xml version="1.0" encoding="UTF-8" ?>
+<odoo>
+ <record id="coupon" model="product.product">
+ <field name="name">Coupon</field>
+ <field name="type">service</field>
+ </record>
+</odoo>


Is this needed with current coupon logic?

hparfr · 2021-05-20T10:01:09Z

Why not. I was not aware of this coupon module.

hailangvn · 2021-05-20T14:11:24Z

My comment was about demo coupon product, which IMHO helps new user to understand this module. I was wondering what to do next after having a coupon product while we already added coupon code to promotions page. There is another demo file as well.

rousseldenis · 2021-05-20T18:05:25Z

sale_promotion_rule/views/sale_promotion_rule.xml

+ <field name="multi_rule_strategy" />
+ </group>
+ <group name="condition" string="Condition" col="3">
+ <label for="date_from" string="Date début/fin" />


Could you change this to English version ?

@xavier-bouquiaux

ping @xavier-bouquiaux

francesco-ooops · 2022-05-13T15:54:21Z

@xavier-bouquiaux @rousseldenis wouldn't it make more sense to move this module to sale-promotion repo?

let us know if you need us to work on it

francesco-ooops · 2022-05-13T15:58:26Z

or rather: what are the differences between this module's promotions and odoo standard promotions? should they coexist?

hparfr · 2022-05-13T19:56:26Z

or rather: what are the differences between this module's promotions and odoo standard promotions? should they coexist?

After few months of implementation with coupons in v14, it's missing key features for our e-commerce case (like apply more than 1 promotion at time). Coupon is not designed to allow behavior changes. So it's a bit hacky to add features on top of it. We spent a lot of effort to make it work.

Sale promotion rule, is an old module date here from 2017 and I think it came from a time when we had to synchronize with Magento / Prestashop and cover main features. It's designed and implemented to allow behavior changes if needed. I think a good refactoring will not hurt.

Like always, it depends of your needs and your budget.

rousseldenis · 2022-05-16T17:59:29Z

@Cedric-Pigeon

rousseldenis · 2022-06-13T13:21:10Z

After few months of implementation with coupons in v14, it's missing key features for our e-commerce case (like apply more than 1 promotion at time). Coupon is not designed to allow behavior changes. So it's a bit hacky to add features on top of it. We spent a lot of effort to make it work.

@hparfr But from 13 version, it is possible to use coupon for its model only and build on top of it as we did here : https:/acsone/acsone-addons/tree/14.0/account_wallet_coupon

github-actions · 2023-05-21T12:20:53Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

sebastienbeau

LGTM (code review), we should merge it even odoo have an alternative implementation (coupon do not solve all case). In a long terme we should see if we can use coupon or improve this module.
For now some customer need such feature so let's merge it

sebastienbeau · 2023-06-14T06:57:11Z

sale_promotion_rule/views/sale_promotion_rule.xml

+ <field name="multi_rule_strategy" />
+ </group>
+ <group name="condition" string="Condition" col="3">
+ <label for="date_from" string="Date début/fin" />


ping @xavier-bouquiaux

The module now supports multiple promotion rules. When a coupon is used, it always take precedence on automatic promotion rule. The computation of promotions has been refactored to update lines from the sale.order object. Sine lines are updated from the SO, the recompute of SO fields that depends of lines is only tiggered at the end of the update on the lines. (In place of each time a line is updated). You can ask to recompute the promotion of a sale.order. If a coupon is already specified it's conserved but all the automatic rules are applied again.

If the coupon rule apply a discount in fixed price, the rule should not be applied on each sale order line

Sequence order was never applied du of missing _order [UPD] Update sale_promotion_rule.pot

Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-10.0/sale-workflow-10.0-sale_promotion_rule Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_promotion_rule/ [UPD] Update sale_promotion_rule.pot Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-10.0/sale-workflow-10.0-sale_promotion_rule Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_promotion_rule/ Update translation files Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-10.0/sale-workflow-10.0-sale_promotion_rule Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-10-0/sale-workflow-10-0-sale_promotion_rule/

If no rule is percentage (i.e. edit discount field) we should not clear the discount when removing promotions.

Fix tests using demo data modified by other modules

…on_rules

…uplicates

xavier-bouquiaux · 2023-06-14T07:55:56Z

LGTM (code review), we should merge it even odoo have an alternative implementation (coupon do not solve all case). In a long terme we should see if we can use coupon or improve this module. For now some customer need such feature so let's merge it

Changed to english version and rebased

regards

xbo

sebastienbeau · 2023-06-14T08:50:45Z

/ocabot merge patch

OCA-git-bot · 2023-06-14T08:50:52Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-1583-by-sebastienbeau-bump-patch, awaiting test results.

OCA-git-bot · 2023-06-14T09:18:00Z

Congratulations, your PR was merged at c9dc6ab. Thanks a lot for contributing to OCA. ❤️

rousseldenis added this to the 14.0 milestone May 17, 2021

rousseldenis added migration work in progress labels May 17, 2021

rousseldenis mentioned this pull request May 17, 2021

Migration to version 14.0 #1274

Open

87 tasks

rousseldenis added needs review and removed work in progress labels May 18, 2021

rousseldenis mentioned this pull request May 18, 2021

[14.0][MIG] sale_promotion_rule_assortment #1584

Merged

rousseldenis changed the title ~~[WIP][14.0][MIG] sale promotion rule~~ [14.0][MIG] sale promotion rule May 18, 2021

rousseldenis mentioned this pull request May 18, 2021

[14.0][MIG] sale_promotion_rule_delivery #1585

Merged

hailangvn approved these changes May 19, 2021

View reviewed changes

rousseldenis reviewed May 20, 2021

View reviewed changes

acsonefho mentioned this pull request Aug 10, 2021

[14.0][MIG] shopinvader_promotion_rule from 13.0 shopinvader/odoo-shopinvader#1064

Merged

2 tasks

rousseldenis mentioned this pull request Sep 20, 2021

[14.0][MIG] sale_promotion_rule_display_discount_amount #1586

Merged

2 tasks

acsonefho force-pushed the 14-sale_promotion_rule branch from 8b6b6d1 to 4c95642 Compare January 3, 2022 07:22

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 21, 2023

sebastienbeau approved these changes Jun 14, 2023

View reviewed changes

OCA-git-bot added the approved label Jun 14, 2023

bguillot and others added 4 commits June 14, 2023 09:53

sale_promotion_rule: module to manage promotion rules

115979d

sale_promotion_rule: add button to clean promotion rule

d90ecc3

[IMP] sale_promotion_rule: Improve README

1164b3a

rousseldenis and others added 18 commits June 14, 2023 09:53

[10.0][FIX] sale_promotion_rule: Apply coupon to lines if percentage

e0a8614

If the coupon rule apply a discount in fixed price, the rule should not be applied on each sale order line

sale_promotion_rule 10.0.2.1.0

3e8a838

[10.0][FIX] sale_promotion_rule: Enable sequence order

89c1413

Sequence order was never applied du of missing _order [UPD] Update sale_promotion_rule.pot

[IMP] sale_promotion_rule: black, isort, prettier

bc89856

[MIG] 12.0 sale_promotion_rule

08d56f2

[IMP] sale_promotion_rule: black, isort, prettier

7899132

[MIG] sale_promotion_rule: Migration to 13.0

d4f9692

[FIX] Clear promotion keep manual discount

a777717

If no rule is percentage (i.e. edit discount field) we should not clear the discount when removing promotions.

[IMP] sale_promotion_rule : black, isort, prettier

83b2e85

[WIP][14.0][MIG] sale_promotion_rule

32df8f9

[IMP] Add sale demo data

3437208

Fix tests using demo data modified by other modules

[WIP][14.0][MIG] sale_promotion_rule

e810bbf

[14.0][IMP] sale_promotion_rule: Add test for multi currency case

c02b40e

[14.0][IMP] sale_promotion_rule: Improve coverage testing wizard

980ca72

[14.0][IMP] sale_promotion_rule: Improve coverage testing has_promoti…

0b34b56

…on_rules

[14.0][i18n] sale_promotion_rule: Regenerate pot and merge to avoid d…

826ba2e

…uplicates

[10.0][ADD] Add company_id + related rules

9390ffd

xavier-bouquiaux force-pushed the 14-sale_promotion_rule branch from 4c95642 to 9390ffd Compare June 14, 2023 07:53

[IMP] sale_promotion_rule : translate field

93d60f4

[IMP] pre-commit update

7949471

OCA-git-bot added the bot is merging ⏳ label Jun 14, 2023

OCA-git-bot merged commit 259d4fd into OCA:14.0 Jun 14, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 14, 2023

acsonefho deleted the 14-sale_promotion_rule branch June 14, 2023 12:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][MIG] sale promotion rule #1583

[14.0][MIG] sale promotion rule #1583

xavier-bouquiaux commented May 11, 2021

rousseldenis commented May 18, 2021 •

edited

Loading

hailangvn left a comment

hailangvn May 19, 2021

rousseldenis Sep 20, 2021

hailangvn Sep 20, 2021

hailangvn May 19, 2021

hparfr commented May 20, 2021

hailangvn commented May 20, 2021

rousseldenis May 20, 2021

rousseldenis Sep 20, 2021

sebastienbeau Jun 14, 2023

francesco-ooops commented May 13, 2022

francesco-ooops commented May 13, 2022

hparfr commented May 13, 2022

rousseldenis commented May 16, 2022

rousseldenis commented Jun 13, 2022 •

edited

Loading

github-actions bot commented May 21, 2023

sebastienbeau left a comment

sebastienbeau Jun 14, 2023

xavier-bouquiaux commented Jun 14, 2023

sebastienbeau commented Jun 14, 2023

OCA-git-bot commented Jun 14, 2023

OCA-git-bot commented Jun 14, 2023

[14.0][MIG] sale promotion rule #1583

[14.0][MIG] sale promotion rule #1583

Conversation

xavier-bouquiaux commented May 11, 2021

rousseldenis commented May 18, 2021 • edited Loading

hailangvn left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hparfr commented May 20, 2021

hailangvn commented May 20, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

francesco-ooops commented May 13, 2022

francesco-ooops commented May 13, 2022

hparfr commented May 13, 2022

rousseldenis commented May 16, 2022

rousseldenis commented Jun 13, 2022 • edited Loading

github-actions bot commented May 21, 2023

sebastienbeau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

xavier-bouquiaux commented Jun 14, 2023

sebastienbeau commented Jun 14, 2023

OCA-git-bot commented Jun 14, 2023

OCA-git-bot commented Jun 14, 2023

rousseldenis commented May 18, 2021 •

edited

Loading

rousseldenis commented Jun 13, 2022 •

edited

Loading